Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rule S2077: support for additional database libraries: NHibernate #6193

Merged
merged 12 commits into from
Oct 13, 2022
Merged

Rule S2077: support for additional database libraries: NHibernate #6193

merged 12 commits into from
Oct 13, 2022

Conversation

martin-strecker-sonarsource
Copy link
Contributor

Part of #3905

@martin-strecker-sonarsource martin-strecker-sonarsource mentioned this pull request Oct 11, 2022
Closed
11 tasks
@github-actions github-actions bot added this to In progress in Best Kanban Oct 11, 2022
@martin-strecker-sonarsource martin-strecker-sonarsource marked this pull request as ready for review October 12, 2022 13:14
@github-actions github-actions bot moved this from In progress to Review in progress in Best Kanban Oct 12, 2022
pavel-mikula-sonarsource
pavel-mikula-sonarsource requested changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be simplified a little

analyzers/src/SonarAnalyzer.Common/Rules/Hotspots/ExecutingSqlQueriesBase.cs Outdated Show resolved Hide resolved
analyzers/src/SonarAnalyzer.Common/Rules/Hotspots/ExecutingSqlQueriesBase.cs Show resolved Hide resolved
@pavel-mikula-sonarsource pavel-mikula-sonarsource moved this from Review in progress to In progress in Best Kanban Oct 13, 2022
@github-actions github-actions bot moved this from In progress to Review in progress in Best Kanban Oct 13, 2022
pavel-mikula-sonarsource
pavel-mikula-sonarsource approved these changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one more line to remove

analyzers/src/SonarAnalyzer.Common/Helpers/KnownType.cs Outdated Show resolved Hide resolved
Best Kanban automation moved this from Review in progress to Review approved Oct 13, 2022
@martin-strecker-sonarsource @pavel-mikula-sonarsource
Update analyzers/src/SonarAnalyzer.Common/Helpers/KnownType.cs
62f34d8 
Co-authored-by: Pavel Mikula <57188685+pavel-mikula-sonarsource@users.noreply.github.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Oct 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@martin-strecker-sonarsource martin-strecker-sonarsource deleted the Martin/S2077_NHibernate branch October 13, 2022 17:09
Best Kanban automation moved this from Review approved to Validate Peach Oct 13, 2022
@martin-strecker-sonarsource martin-strecker-sonarsource moved this from Validate Peach to Done in Best Kanban Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavel-mikula-sonarsource pavel-mikula-sonarsource pavel-mikula-sonarsource approved these changes

Assignees

@martin-strecker-sonarsource martin-strecker-sonarsource

Labels
None yet
Projects
Best Kanban
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@martin-strecker-sonarsource @pavel-mikula-sonarsource